feat(Tabs): ✨ New Tabs Component
#876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magnusrm
force-pushed
the
feat/tabs-component
branch
from
769f178 to
1f02ebe
Compare
|
Storybook preview deployment is available at https://storybook-8xevsz1h1-designsystemet.vercel.app |
mimarz
requested changes
Oct 3, 2023
packages/react/src/components/Tabs/TabContent/TabContent.module.css
Outdated
Show resolved
Hide resolved
| <RovingTabindexItem | ||
| {...rest} | ||
| {...buttonProps} | ||
| as={'button'} |
There was a problem hiding this comment.
We could also just pass our own Button into the as prop here. It would save us for a lot of repitition. But maybe save that for later as we have planned to do changes to the Button and its api now 😅
|
Storybook preview deployment is available at https://storybook-cpx5a1lth-designsystemet.vercel.app |
mimarz
reviewed
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #872